K8s auto-instrumentation details and example (Node.js) #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentm
reviewed
Nov 29, 2024
Merged
Contributor
Author
|
@trentm , thanks a lot for your review here. I will consider everything you have mentioned here, but in some of the topics we had already changed those sentences (sorry I hadn't told you before about it). I'll ping you and make comments as soon as I apply the changes. Thanks a lot! |
eedugon
commented
Dec 3, 2024
eedugon
commented
Dec 3, 2024
eedugon
commented
Dec 3, 2024
eedugon
commented
Dec 3, 2024
eedugon
commented
Dec 3, 2024
Co-authored-by: Mike Birnstiehl <[email protected]>
trentm
reviewed
Dec 11, 2024
Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
Contributor
Author
|
Thanks a lot @trentm for your help here! I think we are ready for merging / final review. FYI I have removed also the |
trentm
approved these changes
Dec 14, 2024
Co-authored-by: Trent Mick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding document
docs/kubernetes/operator/instrumenting-nodejs.mdwith details for instrumenting Node.js applications on kubernetes with the EDOT Node.js and the operator.@trentm , if possible I'd like your review on this:
init container to copy the SDK to a shared volumeplus a configuration in the main container to use the SDK throughNODE_OPTIONSenv var, but I'm not sure.This PR is similar similar to:
#54 (Java)
#58 (Python)